Skip to content
This repository was archived by the owner on Aug 15, 2019. It is now read-only.

Conversation

@dsmilkov
Copy link
Contributor

@dsmilkov dsmilkov commented Oct 4, 2017

ping @cghawthorne


This change is Reviewable

@dsmilkov dsmilkov requested a review from nsthorat October 4, 2017 23:05
@nsthorat
Copy link
Contributor

nsthorat commented Oct 4, 2017

:lgtm_strong:


Reviewed 7 of 8 files at r1, 1 of 2 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


demos/performance_rnn/performance_rnn.ts, line 107 at r1 (raw file):

  document.querySelector('#status').innerHTML =
      'We do not yet support your device. Please try on ' +
      'a desktop computer with Chrome/Firefox, or an Android phone.';

with WebGL


Comments from Reviewable

@cghawthorne
Copy link
Contributor

:lgtm_strong:


Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.


Comments from Reviewable

@dsmilkov
Copy link
Contributor Author

dsmilkov commented Oct 4, 2017

Review status: 7 of 8 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.


demos/performance_rnn/performance_rnn.ts, line 107 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

with WebGL

Done.


Comments from Reviewable

@dsmilkov dsmilkov merged commit 10a3779 into master Oct 4, 2017
@dsmilkov dsmilkov deleted the perf-demo branch October 4, 2017 23:24
mnottheone pushed a commit to mnottheone/deeplearnjs that referenced this pull request Dec 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants