This repository was archived by the owner on Aug 15, 2019. It is now read-only.
Fix gradients for onesLikes / zerosLike#1753
Merged
caisq merged 6 commits intotensorflow:masterfrom May 13, 2019
Merged
Conversation
Contributor
|
FYI I am on vacation this week, this fix is fine for now but we should really fix this properly by stopping gradient propagation when we have null gradients @dsmilkov |
nsthorat
approved these changes
May 13, 2019
Contributor
nsthorat
left a comment
nsthorat
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @dsmilkov and @nsthorat)
dsmilkov
approved these changes
May 13, 2019
Contributor
dsmilkov
left a comment
dsmilkov
left a comment
There was a problem hiding this comment.
Reviewable status:
Contributor
|
tensorflow/tfjs#619 tracks the special "null" for gradients. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes tensorflow/tfjs#1398
BUG
This change is