Skip to content
This repository was archived by the owner on Aug 15, 2019. It is now read-only.

Conversation

@nsthorat
Copy link
Contributor

@nsthorat nsthorat commented Aug 12, 2017

This change is Reviewable

Fixes #22

@dsmilkov
Copy link
Contributor

:lgtm_strong:


Review status: 0 of 3 files reviewed at latest revision, 4 unresolved discussions.


demos/intro/index.html, line 1 at r1 (raw file):

<h1>Introduction tutorial code</h1>

Add copyright header


demos/intro/intro.ts, line 39 at r1 (raw file):

    // Blocking call to actually read the values from average. Waits until the
    // GPU has finished executing the operations before returning values.
    console.log('mean squared difference: ' + average.get());  // average is a Scalar so we use .get()

wrap to 80 width


demos/intro/intro.ts, line 58 at r1 (raw file):

  const labelTensor = g.placeholder('label', labelShape);

  // Variables are containers that hold a value that can be updated from training.

wrap line


demos/intro/intro.ts, line 133 at r1 (raw file):

    console.log('value: ' + testOutput.get(0));
  });
}

should we dispose all inputs and labels here? or too much detail for this tutorial?


Comments from Reviewable

@nsthorat nsthorat merged commit a733567 into master Aug 13, 2017
@dsmilkov dsmilkov deleted the intro-code branch August 13, 2017 23:48
mnottheone pushed a commit to mnottheone/deeplearnjs that referenced this pull request Dec 1, 2018
mnottheone pushed a commit to mnottheone/deeplearnjs that referenced this pull request Dec 1, 2018
…nverge when training. (tensorflow#32)

* Add intro.ts demo that demos intro tutorial, fix intro to actually converge when training.

* remove code accidentally added to intro.md

* Respond to comments, fix line length problems, dispose inputs

* Add link to intro demo from intro md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants