This repository was archived by the owner on Aug 15, 2019. It is now read-only.
Add 80 chars lint rule, fix lint errors, and silence the linter where we have imports > 80. #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… we have imports > 80.
Contributor
|
Review status: 0 of 22 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
mnottheone
pushed a commit
to mnottheone/deeplearnjs
that referenced
this pull request
Dec 1, 2018
… we have imports > 80. (tensorflow#36) * Add 80 chars lint rule, fix lint errors, and silence the linter where we have imports > 80. * add line length silence to intro.ts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, I tried to get imports to have this automatically, but it's not yet supported in tslint.
We'd need eslint, or something like that. I think this is simpler for now
prettier/prettier#1954
This change is