This repository was archived by the owner on Aug 15, 2019. It is now read-only.
Migrate from tsc 2.3.x to tsc 2.4.x #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Reviewed 7 of 7 files at r1. Comments from Reviewable |
mnottheone
pushed a commit
to mnottheone/deeplearnjs
that referenced
this pull request
Dec 1, 2018
* migrate to typescript 2.4.x * shorten travis log by supressing npm run err statements * Merge master into tsc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our project was not building with the new typescript compiler (2.4.x) which is stricter than 2.3.x and has better inference. This leads to user confusion like #37
The migration required very small changes and we'd rather do it sooner than later.
This change is