This repository was archived by the owner on Oct 17, 2021. It is now read-only.
Support compilation with strictNullChecks#214
Closed
sandersn wants to merge 1 commit intotensorflow:masterfrom
Closed
Support compilation with strictNullChecks#214sandersn wants to merge 1 commit intotensorflow:masterfrom
sandersn wants to merge 1 commit intotensorflow:masterfrom
Conversation
Currently, Sequential is not a valid subclass of Layer because its build method has type `build(inputShape?: Shape | undefined)` whereas Layer's build method has type `build(inputShape: Shape | Shape[])`. This breaks when trying to use Sequential in a project that has --strictNullChecks turned on for the Typescript compiler because Layer.build never expects undefined. The most obvious fix is to make Layer.build's inputShape parameter optional as well. That's what I did, but I'm not sure it's correct -- I *just* started using tensorflow but ran into problems when I tried setting strictNullChecks to true. The other fix would be to make Sequential.build have type `build(inputShape: Shape)` -- that is, to require the inputShape parameter. But it doesn't even use it, so this seems wrong.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FEATURE
Currently, Sequential is not a valid subclass of Layer because its build method has type
build(inputShape?: Shape | undefined)whereas Layer's build method has typebuild(inputShape: Shape | Shape[]). This breaks when trying to use Sequential in a project that has --strictNullChecks turned on for the Typescript compiler because Layer.build never expects undefined.The most obvious fix is to make Layer.build's inputShape parameter optional as well. That's what I did, but I'm not sure it's correct -- I just started using tensorflow but ran into problems when I tried setting strictNullChecks to true.
The other fix would be to make Sequential.build have type
build(inputShape: Shape)-- that is, to require the inputShape parameter. But it doesn't even use it, so this seems wrong.Fixes tensorflow/tfjs#226
This change is