Remove version from tfjs script tag#202
Closed
xmbrst wants to merge 1 commit intotensorflow:masterfrom
Closed
Conversation
It looks like the version number in the tfjs script tag url is producing an error because of the fix for issue tensorflow#196.
dsmilkov
reviewed
May 13, 2019
Contributor
dsmilkov
left a comment
dsmilkov
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @xmbrst)
universal-sentence-encoder/README.md, line 42 at r1 (raw file):
```js <script src="https://cdn.jsdelivr.net/npm/@tensorflow/tfjs@1.0.0"></script>
Can you change it to 1.1.2 ? We want to keep the versions pinned in case we introduce bugs/unintentional breaking changes
Contributor
|
It looks like this change has now been made to the README. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the version number in the tfjs script tag url is producing an error because of the fix for issue #196.
This change is