Skip to content

Conversation

@lina128
Copy link
Collaborator

@lina128 lina128 commented Apr 1, 2021

This PR adds skeleton to the demo.


This change is Reviewable

@google-cla google-cla bot added the cla: yes label Apr 1, 2021
@lina128 lina128 requested review from mhays-google and pyu10055 April 1, 2021 19:59
Copy link
Contributor

@mhays-google mhays-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @pyu10055)

@lina128 lina128 merged commit a42d197 into tensorflow:master Apr 1, 2021
@lina128 lina128 deleted the demo branch April 1, 2021 20:10
Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @lina128)


pose-detection/demo/src/camera.js, line 107 at r1 (raw file):

   * Draw the keypoints on the video.
   * @param keypoints A list of keypoints, may be normalized.
   * @param shouldScale If the keypoints are normalized, shouldScale should be

update the param doc, maybe reverse the parameter order of scaleX and scaleY

@lina128
Copy link
Collaborator Author

lina128 commented Apr 1, 2021

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @lina128)

pose-detection/demo/src/camera.js, line 107 at r1 (raw file):

   * Draw the keypoints on the video.
   * @param keypoints A list of keypoints, may be normalized.
   * @param shouldScale If the keypoints are normalized, shouldScale should be

update the param doc, maybe reverse the parameter order of scaleX and scaleY

Updated in #631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants