This repository was archived by the owner on Sep 17, 2022. It is now read-only.
Conversation
nkreeger
suggested changes
Apr 2, 2019
scripts/publish-npm.sh
Outdated
| # Publish the CPU package | ||
| npm publish | ||
| # Publish the GPU package | ||
| ls tensorflow-tfjs-node-gpu* | xargs npm publish |
Contributor
There was a problem hiding this comment.
Curious - does this prevent publishing all tfjs-node-gpu* packages? Once you run this script you have the generated tarballs lying around in the directory.
Author
There was a problem hiding this comment.
Added some protection for non-1 tarballs.
nkreeger
approved these changes
Apr 2, 2019
Contributor
nkreeger
left a comment
nkreeger
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @nkreeger and @nsthorat)
scripts/publish-npm.sh, line 33 at r2 (raw file):
Quoted 4 lines of code…
# if [ "$BRANCH" != "master" ] && [ "$BRANCH" != "0.3.x" ]; then # echo "Error: Switch to the master or a release branch before publishing." # exit # fi
Does this need to be cleaned up?
nsthorat
commented
Apr 2, 2019
Author
nsthorat
left a comment
nsthorat
left a comment
There was a problem hiding this comment.
Reviewable status:
scripts/publish-npm.sh, line 33 at r2 (raw file):
Previously, nkreeger (Nick Kreeger) wrote…
# if [ "$BRANCH" != "master" ] && [ "$BRANCH" != "0.3.x" ]; then # echo "Error: Switch to the master or a release branch before publishing." # exit # fiDoes this need to be cleaned up?
old diff, this is back
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is