-
Notifications
You must be signed in to change notification settings - Fork 2k
tfjs-webgpu: Improved timing in benchmarks. #1823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nsthorat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, and @nsthorat)
tfjs-webgpu/src/benchmark_ops_test.ts, line 118 at r1 (raw file):
// tslint:disable-next-line:ban xit('add', async () => {
remove the xits?
annxingyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @dsmilkov and @nsthorat)
tfjs-webgpu/src/benchmark_ops_test.ts, line 118 at r1 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
remove the xits?
I think we don't want them to run as part of the default test suite - is there a better way to exclude?
nsthorat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @annxingyuan and @dsmilkov)
tfjs-webgpu/src/benchmark_ops_test.ts, line 118 at r1 (raw file):
Previously, annxingyuan (Ann Yuan) wrote…
I think we don't want them to run as part of the default test suite - is there a better way to exclude?
can you exclude them in the karma config?
annxingyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @dsmilkov)
tfjs-webgpu/src/benchmark_ops_test.ts, line 118 at r1 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
can you exclude them in the karma config?
Done
Changes:
disposeAfterEachTrialargument to toggle whether we tidy after each trialendTrialasync so we account for read times in profilerepsdefault to1for fairer comparison against WebGLTo see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is