Skip to content

Conversation

@annxingyuan
Copy link
Contributor

@annxingyuan annxingyuan commented Aug 14, 2019

Changes:

  • Add disposeAfterEachTrial argument to toggle whether we tidy after each trial
  • Make endTrial async so we account for read times in profile
  • Change reps default to 1 for fairer comparison against WebGL
  • Add new binary op benchmark

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, and @nsthorat)


tfjs-webgpu/src/benchmark_ops_test.ts, line 118 at r1 (raw file):

  // tslint:disable-next-line:ban
  xit('add', async () => {

remove the xits?

Copy link
Contributor Author

@annxingyuan annxingyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov and @nsthorat)


tfjs-webgpu/src/benchmark_ops_test.ts, line 118 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

remove the xits?

I think we don't want them to run as part of the default test suite - is there a better way to exclude?

Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @annxingyuan and @dsmilkov)


tfjs-webgpu/src/benchmark_ops_test.ts, line 118 at r1 (raw file):

Previously, annxingyuan (Ann Yuan) wrote…

I think we don't want them to run as part of the default test suite - is there a better way to exclude?

can you exclude them in the karma config?

Copy link
Contributor Author

@annxingyuan annxingyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov)


tfjs-webgpu/src/benchmark_ops_test.ts, line 118 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

can you exclude them in the karma config?

Done

@annxingyuan annxingyuan merged commit 28923ef into master Aug 15, 2019
@annxingyuan annxingyuan deleted the improve_webgpu_bench branch August 15, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants