Skip to content

Conversation

@dsmilkov
Copy link
Contributor

@dsmilkov dsmilkov commented Aug 15, 2019

worker_node_test.ts in tfjs-core contains a conditional require statement
that confuses the bundler of karma-typescript.

Ignoring that file at the bundler stage fixes the problem


This change is Reviewable

@dsmilkov dsmilkov requested a review from annxingyuan August 15, 2019 15:08
@dsmilkov dsmilkov changed the title Ignore worker_node_test in webgpu karma's bundler [tfjs-core] Ignore worker_node_test in webgpu karma's bundler Aug 15, 2019
Copy link
Contributor

@annxingyuan annxingyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks Daniel!

@dsmilkov dsmilkov merged commit 512a9cd into master Aug 15, 2019
@dsmilkov dsmilkov deleted the fix-webgpu-tet branch August 15, 2019 16:48
caisq pushed a commit to caisq/tfjs-1 that referenced this pull request Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants