Skip to content

[converter] Fix bazel BUILD rules for wizard #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2019
Merged

[converter] Fix bazel BUILD rules for wizard #1953

merged 2 commits into from
Sep 5, 2019

Conversation

@caisq
Copy link
Contributor

@caisq caisq commented Sep 2, 2019 •
edited
Loading

  • Move wizard.py and the associated test file from python/tensorflowjs to python/tensorfflowjs/converters. This is logical, because converters.py resides in the latter directory.
  • Adjust BUILD rules accordingly.
  • Fix some missing BUILD dependencies.

DEV

This change is Reviewable

@caisq caisq requested a review from pyu10055 September 2, 2019 02:46
pyu10055
pyu10055 approved these changes Sep 3, 2019
View reviewed changes
Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Reviewable status: 0 of 1 approvals obtained (waiting on @pyu10055)

@caisq caisq merged commit ea8d5b3 into tensorflow:master Sep 5, 2019
@caisq caisq deleted the wizard-bazel-fixes branch September 5, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pyu10055 pyu10055 pyu10055 approved these changes

Assignees

@pyu10055 pyu10055

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@caisq @pyu10055 @googlebot