[WebGPU] Don't release the uniform buffer under delayed mode #1968
Conversation
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
In delayed mode, the command list hasn't been executed actually. So, the uniform buffer can't be recycled. This patch also fixes the issue that PostNet works incorrectly under delayed mode.
|
@annxingyuan @kainino0x Please take a look. Thanks. |
annxingyuan
left a comment
annxingyuan
left a comment
There was a problem hiding this comment.
LGTM! This was a huge oversight on my part... thank you for fixing this @qjia7 :)
4 participants
BUG
In delayed mode, the command list hasn't been executed actually.
So, the uniform buffer can't be recycled.
This patch also fixes the issue that PostNet works incorrectly under
delayed mode.
This change is