[tfjs-core] Fix caching on cpu with async reads #1974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsthorat
approved these changes
Sep 4, 2019
Contributor
nsthorat
left a comment
nsthorat
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @annxingyuan and @nsthorat)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG, PERF
This PR fixes a bug introduced in tensorflow/tfjs-core#1798
The values were not cached after an async read, which has performance implications.
The inference of an AutoML object detection model including post-processing changed from 107ms to 80ms. The reason could be an accumulation of repeated reads done by the converter executor when we call
model.executeAsync().This change is