webgpu: Fix the compile error in conv2d_naive shader #2002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUG When switch to the naive method of conv2d, below error will be met: Error: Shader compilation failed: file:124: error: 'getX' : no matching overloaded function found. Error: Shader compilation failed: file:131: error: 'getW' : no matching overloaded function found. The fixing uses the right get* methods. And uses int instead of uint as the parameter type.
Contributor
Author
|
@annxingyuan @kainino0x Please take a look. Thanks. FYI: I can't reproduce the performance regression we met before qjia7/tfjs-webgl2compute#13 which I ever mentioned in our last meeting. I am not sure if you ever did some changes in your current conv2d_mm method. Anyway it's a good news. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG
When switch to the naive method of conv2d, below error will be met:
Error: Shader compilation failed: file:124: error: 'getX' : no matching overloaded function found.
Error: Shader compilation failed: file:131: error: 'getW' : no matching overloaded function found.
The fixing uses the right get* methods. And uses int instead of uint as the parameter type.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is