[WASM] Add exp
#2517
Merged
[WASM] Add exp
#2517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmilkov
approved these changes
Dec 9, 2019
Contributor
dsmilkov
left a comment
dsmilkov
left a comment
There was a problem hiding this comment.
Thank you. I can follow up in another PR to make tfjs-core call the registered 'Exp' kernel and that we run core's unit tests against this implementation. I'll cc in you the PR.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @dsmilkov)
dsmilkov
added a commit
that referenced
this pull request
Dec 9, 2019
Continuation of #2517 - Make tfjs-core call `Exp` as a modular kernel - Run core's Exp unit tests against wasm backend FEATURE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is