[node] Update libtensorflow version to 1.15.0 #2552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmilkov
approved these changes
Dec 13, 2019
Contributor
dsmilkov
left a comment
dsmilkov
left a comment
There was a problem hiding this comment.
Awesome. I think this deserves a minor version bump (middle number) on node, since its primary dependency has changed, which could potentially lead to different behavior.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @dsmilkov and @pyu10055)
kangyizhang
commented
Dec 13, 2019
Contributor
Author
kangyizhang
left a comment
kangyizhang
left a comment
There was a problem hiding this comment.
Yes I agree. Thanks for reminding. I'll keep this in mind and make it happen in the next release.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been tested on Linux/Mac/Windows for both CPU/GPU
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is