Skip to content

Conversation

@nsthorat
Copy link
Contributor

@nsthorat nsthorat commented Dec 16, 2019

The cache will always get hit because the key is simply 1.

We keep the std::map so this code can be copy pasted without having to think.

This change is Reviewable

Nikhil Thorat added 3 commits December 30, 2019 09:28
@nsthorat nsthorat changed the title [NOT READY] [WASM] Use XNNPack for Sigmoid. Use XNNPack for Sigmoid. Dec 30, 2019
@nsthorat nsthorat requested a review from dsmilkov December 30, 2019 14:42
Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov)

@nsthorat nsthorat merged commit b9da49a into master Jan 2, 2020
@nsthorat nsthorat deleted the sigmoid branch January 2, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants