Skip to content

Conversation

@dsmilkov
Copy link
Contributor

@dsmilkov dsmilkov commented Dec 17, 2019

This change is Reviewable

Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov, @nsthorat, and @pyu10055)


tfjs-core/src/backends/webgl/backend_webgl.ts, line 2632 at r1 (raw file):

      return;
    }
    if (!ENV.getBool('IS_TEST')) {

use env(), ENV is going to go away


tfjs-core/src/backends/webgl/backend_webgl_test.ts, line 240 at r1 (raw file):

    tf.backend().dispose();

    // Make sure the cache is empty.

instead of this how about just making a new MathBackendWebGL() and making sure new things can be run (rather than checking these implementation details)?

Copy link
Contributor Author

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @pyu10055)


tfjs-core/src/backends/webgl/backend_webgl.ts, line 2632 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

use env(), ENV is going to go away

Done.


tfjs-core/src/backends/webgl/backend_webgl_test.ts, line 240 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

instead of this how about just making a new MathBackendWebGL() and making sure new things can be run (rather than checking these implementation details)?

talked offline. third unit test does that test. The first two unit tests are there to protect against future changes of removing the disposal logic

Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Reviewable status: :shipit: complete! 2 of 1 approvals obtained (waiting on @pyu10055)

@dsmilkov dsmilkov merged commit b97dbea into master Dec 17, 2019
@dsmilkov dsmilkov deleted the improve-bench branch December 17, 2019 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants