Skip to content

Conversation

@nsthorat
Copy link
Contributor

@nsthorat nsthorat commented Dec 17, 2019

Note that the implementation of Tile is the naive implementation. This can be made faster with memcpys (or xnnpack).

These are the final ops needed for AutoML object detection.

This change is Reviewable

@nsthorat nsthorat changed the title [WASM] Add Less and LessEqual. [WASM] Add Less, LessEqual, LogicalAnd. Dec 17, 2019
@nsthorat nsthorat changed the title [WASM] Add Less, LessEqual, LogicalAnd. [WASM] Add Less, LessEqual, LogicalAnd, Tile. Dec 17, 2019
Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome to have support for AutoML Object!

Reviewed 27 of 27 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, and @nsthorat)


tfjs-backend-wasm/src/cc/kernels/Tile.cc, line 27 at r1 (raw file):

namespace {
template <typename T>
void tile(const T* x_data, const std::vector<size_t>& x_shape,

rename to tileSlow for consistency with the other kernels


tfjs-core/benchmarks/index.html, line 87 at r1 (raw file):

    </table>
  </div>
  <script src="/tfjs-core/dist/tf-core.js"></script>

revert these changes


tfjs-core/src/backends/tile_impl.ts, line 38 at r1 (raw file):

    const originalLoc: number[] = new Array(xBuf.rank);
    for (let j = 0; j < originalLoc.length; j++) {

just double checking, this wasn't a bug because the scoping of let, right?

Copy link
Contributor Author

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @annxingyuan and @dsmilkov)


tfjs-backend-wasm/src/cc/kernels/Tile.cc, line 27 at r1 (raw file):

Previously, dsmilkov (Daniel Smilkov) wrote…

rename to tileSlow for consistency with the other kernels

Done


tfjs-core/benchmarks/index.html, line 87 at r1 (raw file):

Previously, dsmilkov (Daniel Smilkov) wrote…

revert these changes

Done


tfjs-core/src/backends/tile_impl.ts, line 38 at r1 (raw file):

Previously, dsmilkov (Daniel Smilkov) wrote…

just double checking, this wasn't a bug because the scoping of let, right?

Correct, not a bug because of scoping but just confusing when reading :)

@nsthorat nsthorat merged commit c44bf32 into master Dec 17, 2019
@nsthorat nsthorat deleted the lessequal branch December 17, 2019 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants