-
Notifications
You must be signed in to change notification settings - Fork 2k
[WASM] Add Less, LessEqual, LogicalAnd, Tile. #2578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dsmilkov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome to have support for AutoML Object!
Reviewed 27 of 27 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, and @nsthorat)
tfjs-backend-wasm/src/cc/kernels/Tile.cc, line 27 at r1 (raw file):
namespace { template <typename T> void tile(const T* x_data, const std::vector<size_t>& x_shape,
rename to tileSlow for consistency with the other kernels
tfjs-core/benchmarks/index.html, line 87 at r1 (raw file):
</table> </div> <script src="/tfjs-core/dist/tf-core.js"></script>
revert these changes
tfjs-core/src/backends/tile_impl.ts, line 38 at r1 (raw file):
const originalLoc: number[] = new Array(xBuf.rank); for (let j = 0; j < originalLoc.length; j++) {
just double checking, this wasn't a bug because the scoping of let, right?
nsthorat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @annxingyuan and @dsmilkov)
tfjs-backend-wasm/src/cc/kernels/Tile.cc, line 27 at r1 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
rename to tileSlow for consistency with the other kernels
Done
tfjs-core/benchmarks/index.html, line 87 at r1 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
revert these changes
Done
tfjs-core/src/backends/tile_impl.ts, line 38 at r1 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
just double checking, this wasn't a bug because the scoping of
let, right?
Correct, not a bug because of scoping but just confusing when reading :)
Note that the implementation of Tile is the naive implementation. This can be made faster with memcpys (or xnnpack).
These are the final ops needed for AutoML object detection.
This change is