Skip to content

Conversation

@annxingyuan
Copy link
Contributor

@annxingyuan annxingyuan commented Dec 20, 2019

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@annxingyuan annxingyuan changed the title WIP [wasm] Gather, GatherND kernels. [wasm] Add Gather, GatherNd kernels. Dec 23, 2019
@annxingyuan annxingyuan requested a review from nsthorat December 23, 2019 20:20
@annxingyuan annxingyuan requested a review from dsmilkov December 23, 2019 20:20
@annxingyuan annxingyuan self-assigned this Dec 23, 2019
Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 12 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, and @nsthorat)


tfjs-backend-wasm/src/cc/kernels/Gather.cc, line 50 at r1 (raw file):

#endif

void Gather(const size_t x_id, const DType dtype, const size_t* x_strides_ptr,

this should be int32_t


tfjs-backend-wasm/src/cc/kernels/Gather.cc, line 52 at r1 (raw file):

void Gather(const size_t x_id, const DType dtype, const size_t* x_strides_ptr,
            const size_t strides_size, const size_t indices_id,
            const size_t axis, const size_t* out_strides_ptr,

this should be int32_t


tfjs-backend-wasm/src/cc/kernels/GatherNd.cc, line 25 at r1 (raw file):

template <typename T>
void gathernd_impl(const T* x_ptr, const int* indices_ptr,

this should be int32_t


tfjs-backend-wasm/src/cc/kernels/GatherNd.cc, line 28 at r1 (raw file):

                   const size_t num_slices, const size_t slice_rank,
                   const size_t slice_size,
                   const std::vector<size_t>& strides_ptr, T* out_buf_ptr) {

this should be int32_t


tfjs-backend-wasm/src/cc/kernels/GatherNd.cc, line 60 at r1 (raw file):

void GatherNd(const size_t x_id, const DType dtype, const size_t indices_id,
              const size_t num_slices, const size_t slice_rank,
              const size_t slice_size, const size_t* strides_ptr,

this should be int32_t

Copy link
Contributor Author

@annxingyuan annxingyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov)


tfjs-backend-wasm/src/cc/kernels/Gather.cc, line 50 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

this should be int32_t

Done


tfjs-backend-wasm/src/cc/kernels/Gather.cc, line 52 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

this should be int32_t

Done


tfjs-backend-wasm/src/cc/kernels/GatherNd.cc, line 25 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

this should be int32_t

Done


tfjs-backend-wasm/src/cc/kernels/GatherNd.cc, line 28 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

this should be int32_t

Done


tfjs-backend-wasm/src/cc/kernels/GatherNd.cc, line 60 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

this should be int32_t

Done

@annxingyuan annxingyuan merged commit 1fa1beb into master Dec 26, 2019
@annxingyuan annxingyuan deleted the wasm_gather branch December 26, 2019 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants