-
Notifications
You must be signed in to change notification settings - Fork 2k
[wasm] Add Gather, GatherNd kernels. #2601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nsthorat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 12 of 12 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, and @nsthorat)
tfjs-backend-wasm/src/cc/kernels/Gather.cc, line 50 at r1 (raw file):
#endif void Gather(const size_t x_id, const DType dtype, const size_t* x_strides_ptr,
this should be int32_t
tfjs-backend-wasm/src/cc/kernels/Gather.cc, line 52 at r1 (raw file):
void Gather(const size_t x_id, const DType dtype, const size_t* x_strides_ptr, const size_t strides_size, const size_t indices_id, const size_t axis, const size_t* out_strides_ptr,
this should be int32_t
tfjs-backend-wasm/src/cc/kernels/GatherNd.cc, line 25 at r1 (raw file):
template <typename T> void gathernd_impl(const T* x_ptr, const int* indices_ptr,
this should be int32_t
tfjs-backend-wasm/src/cc/kernels/GatherNd.cc, line 28 at r1 (raw file):
const size_t num_slices, const size_t slice_rank, const size_t slice_size, const std::vector<size_t>& strides_ptr, T* out_buf_ptr) {
this should be int32_t
tfjs-backend-wasm/src/cc/kernels/GatherNd.cc, line 60 at r1 (raw file):
void GatherNd(const size_t x_id, const DType dtype, const size_t indices_id, const size_t num_slices, const size_t slice_rank, const size_t slice_size, const size_t* strides_ptr,
this should be int32_t
annxingyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @dsmilkov)
tfjs-backend-wasm/src/cc/kernels/Gather.cc, line 50 at r1 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
this should be int32_t
Done
tfjs-backend-wasm/src/cc/kernels/Gather.cc, line 52 at r1 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
this should be int32_t
Done
tfjs-backend-wasm/src/cc/kernels/GatherNd.cc, line 25 at r1 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
this should be int32_t
Done
tfjs-backend-wasm/src/cc/kernels/GatherNd.cc, line 28 at r1 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
this should be int32_t
Done
tfjs-backend-wasm/src/cc/kernels/GatherNd.cc, line 60 at r1 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
this should be int32_t
Done
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is