Skip to content

Conversation

@pyu10055
Copy link
Collaborator

@pyu10055 pyu10055 commented Dec 30, 2019

Update the tensorflow imports to specifically import compat.v2, since in g3 by default it imports compat.v1

Using latest TF 2.1.0 official release

also fixed #2582

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@pyu10055 pyu10055 changed the title update the tensorflow deps to 2.0.0 update the tensorflow deps to 2.1.0 Jan 2, 2020
Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 16 of 16 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov and @pyu10055)


tfjs-converter/python/requirements.txt, line 4 at r1 (raw file):

numpy>=1.16.4
six>=1.12.0
tensorflow==2.1.0rc2

can this be relaxed to tensorflow>=2.0.0 ?


tfjs-converter/python/tensorflowjs/converters/tf_saved_model_conversion_v2_test.py, line 90 at r1 (raw file):

    graph = tf.Graph()
    with graph.as_default():
      x = tf.compat.v1.placeholder('float32', [2, 2])

is tf.compat.v1 going away in 2.1.0 final (not the RC version)?

Copy link
Collaborator Author

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov)


tfjs-converter/python/requirements.txt, line 4 at r1 (raw file):

Previously, dsmilkov (Daniel Smilkov) wrote…

can this be relaxed to tensorflow>=2.0.0 ?

unfortunately there is a bug on 2.0.0 with keras layers, it failed to save out h5 format for loaded models.


tfjs-converter/python/tensorflowjs/converters/tf_saved_model_conversion_v2_test.py, line 90 at r1 (raw file):

Previously, dsmilkov (Daniel Smilkov) wrote…

is tf.compat.v1 going away in 2.1.0 final (not the RC version)?

it would not

@pyu10055 pyu10055 merged commit 642a541 into master Jan 8, 2020
@pyu10055 pyu10055 deleted the tf_imports branch January 8, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[tfjs-converter/python] Relax requirements

3 participants