-
Notifications
You must be signed in to change notification settings - Fork 2k
update the tensorflow deps to 2.1.0 #2627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dsmilkov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 16 of 16 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @dsmilkov and @pyu10055)
tfjs-converter/python/requirements.txt, line 4 at r1 (raw file):
numpy>=1.16.4 six>=1.12.0 tensorflow==2.1.0rc2
can this be relaxed to tensorflow>=2.0.0 ?
tfjs-converter/python/tensorflowjs/converters/tf_saved_model_conversion_v2_test.py, line 90 at r1 (raw file):
graph = tf.Graph() with graph.as_default(): x = tf.compat.v1.placeholder('float32', [2, 2])
is tf.compat.v1 going away in 2.1.0 final (not the RC version)?
pyu10055
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @dsmilkov)
tfjs-converter/python/requirements.txt, line 4 at r1 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
can this be relaxed to tensorflow>=2.0.0 ?
unfortunately there is a bug on 2.0.0 with keras layers, it failed to save out h5 format for loaded models.
tfjs-converter/python/tensorflowjs/converters/tf_saved_model_conversion_v2_test.py, line 90 at r1 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
is tf.compat.v1 going away in 2.1.0 final (not the RC version)?
it would not
Update the tensorflow imports to specifically import compat.v2, since in g3 by default it imports compat.v1
Using latest TF 2.1.0 official release
also fixed #2582
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is