Fix saving at webworker #2647
Merged
Fix saving at webworker #2647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmilkov
approved these changes
Jan 6, 2020
Contributor
dsmilkov
left a comment
dsmilkov
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @dsmilkov)
dsmilkov
approved these changes
Jan 6, 2020
Contributor
dsmilkov
left a comment
dsmilkov
left a comment
There was a problem hiding this comment.
Thanks!!
Reviewable status: 0 of 1 approvals obtained (waiting on @dsmilkov)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the bug while saving models at webworker env. (#2643)
Note: Under webworker, we can only save models via IndexedDB. Maybe we should mention it at the docs?
This change is