-
Notifications
You must be signed in to change notification settings - Fork 2k
[core] In WebGL, if query timer extension is unavailable, return error object for kernelMs profile. #2726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nsthorat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, and @nsthorat)
tfjs-core/src/backends/webgl/backend_webgl.ts, line 530 at r1 (raw file):
}; if (env().getNumber('WEBGL_DISJOINT_QUERY_TIMER_EXTENSION_VERSION') > 0) {
I think you want WEBGL_DISJOINT_QUERY_TIMER_EXTENSION_RELIABLE
tfjs-core/src/backends/webgl/backend_webgl.ts, line 538 at r1 (raw file):
.map(d => `${d.name}: ${d.ms}`) .join(', '); } else {
possible to add a test for this where we set the flag explicitly to false and check the output?
dsmilkov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 2 of 1 approvals obtained (waiting on @annxingyuan and @dsmilkov)
dsmilkov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No additional comments (+1 to Nikhil's comments)
Reviewable status:
complete! 2 of 1 approvals obtained (waiting on @annxingyuan and @dsmilkov)
annxingyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 2 of 1 approvals obtained
tfjs-core/src/backends/webgl/backend_webgl.ts, line 530 at r1 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
I think you want WEBGL_DISJOINT_QUERY_TIMER_EXTENSION_RELIABLE
Done
tfjs-core/src/backends/webgl/backend_webgl.ts, line 538 at r1 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
possible to add a test for this where we set the flag explicitly to false and check the output?
Done
This PR fixes #2624
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is