-
Notifications
You must be signed in to change notification settings - Fork 2k
[converter] Remove use of browserstack #2734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nsthorat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 approvals obtained (waiting on @dsmilkov, @lina128, @nsthorat, and @pyu10055)
tfjs-converter/package.json, line 61 at r1 (raw file):
"link-local": "yalc link", "publish-local": "yarn build-npm && yalc push", "test": "yarn gen-json --test && karma start",
no more karma for local too right? let's make yarn test call node and call yarn test from test-ci
tfjs-converter/package.json, line 62 at r1 (raw file):
"publish-local": "yarn build-npm && yalc push", "test": "yarn gen-json --test && karma start", "test-ci": "yarn gen-json --test && yarn build && yarn lint && ts-node run_tests.ts",
can you update cloudbuild.yml there is a line called "test-browser" you can rename it
tfjs-converter/package.json, line 64 at r1 (raw file):
"test-ci": "yarn gen-json --test && yarn build && yarn lint && ts-node run_tests.ts", "test-snippets": "ts-node ./scripts/test_snippets.ts", "run-browserstack": "karma start --singleRun --browsers='bs_firefox_mac,bs_chrome_mac' --reporters='dots,karma-typescript,BrowserStack'",
remove this
|
Can you also make sure coverage hasn't decreased by running master against the CPU backend and make sure its the same number (looks like 470: https://pantheon.corp.google.com/cloud-build/builds/b3e40bd6-7734-4b76-98f8-576f3a2a3bb9;step=2?project=learnjs-174218) |
|
Hi @nsthorat , thank you for your review! I cleaned up cloudbuild and package.json. Can you re-review the PR? And yes, the converage is the same. |
nsthorat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @dsmilkov, @lina128, and @pyu10055)
tfjs-converter/cloudbuild.yml, line 62 at r3 (raw file):
entrypoint: 'bash' args: ['./run-python-tests.sh'] waitFor: ['python-build']
how come do we have to wait for python-build now?
Ah, you are right, I thought the previous step is to build package, it's actually just testing package, so they can run in parallel. Changed back to before. |
Converter tests don't need browser to run. Remove browser brings down the test from ~8min to ~5min.
This change is