-
Notifications
You must be signed in to change notification settings - Fork 2k
Update package.json #2762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package.json #2762
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
lina128
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @etiennedupont , package @tensorflow/tfjs is a union package, which includes tfjs-core. So no need to include it again.
|
Hi @lina128, |
nsthorat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @nsthorat)
|
The CI is failing because we have a little script that makes sure tfjs-node and tfjs-node-gpu package.json line up, can you make the change there as well? https://github.com/tensorflow/tfjs/blob/master/tfjs-node-gpu/package.json#L57 Thanks so much! This change is great :) |
|
Hi @nsthorat, thank you for your answer, I made the required change! |
Fixes #2761
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is