-
Notifications
You must be signed in to change notification settings - Fork 2k
[converter] Test against head. #2780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pyu10055
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 approvals obtained (waiting on @dsmilkov, @lina128, @nsthorat, and @pyu10055)
tfjs-converter/package.json, line 58 at r1 (raw file):
"scripts": { "build": "yarn gen-json --test && tsc && copyfiles -f src/data/compiled_api.* dist/src/data/", "build-core": "cd ../tfjs-core && yarn && yarn build",
is this used anywhere?
Yes, it is used in local yarn test. Although we symlinked core. We still have to build core to get the changes and install again to link to the change. |
dsmilkov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @dsmilkov, @nsthorat, and @pyu10055)
tfjs-converter/package.json, line 58 at r1 (raw file):
Previously, lina128 (Na Li) wrote…
Yes, it is used in local yarn test. Although we symlinked core. We still have to build core to get the changes and install again to link to the change.
yup, basically you need the compiled outputs in tfjs-core/dist/... to be up-to-date
dsmilkov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @dsmilkov, @nsthorat, and @pyu10055)
pyu10055
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 2 of 1 approvals obtained (waiting on @nsthorat and @pyu10055)
Change tfjs-converter package to test against head.
This change is