Skip to content

Conversation

@lina128
Copy link
Collaborator

@lina128 lina128 commented Feb 20, 2020

Change tfjs-converter package to test against head.


This change is Reviewable

@lina128 lina128 changed the title Test against head. [converter] Test against head. Feb 20, 2020
Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 approvals obtained (waiting on @dsmilkov, @lina128, @nsthorat, and @pyu10055)


tfjs-converter/package.json, line 58 at r1 (raw file):

  "scripts": {
    "build": "yarn gen-json --test && tsc && copyfiles -f src/data/compiled_api.* dist/src/data/",
    "build-core": "cd ../tfjs-core && yarn && yarn build",

is this used anywhere?

@lina128
Copy link
Collaborator Author

lina128 commented Feb 21, 2020

Reviewable status: 0 of 1 approvals obtained (waiting on @dsmilkov, @lina128, @nsthorat, and @pyu10055)

tfjs-converter/package.json, line 58 at r1 (raw file):

  "scripts": {
    "build": "yarn gen-json --test && tsc && copyfiles -f src/data/compiled_api.* dist/src/data/",
    "build-core": "cd ../tfjs-core && yarn && yarn build",

is this used anywhere?

Yes, it is used in local yarn test. Although we symlinked core. We still have to build core to get the changes and install again to link to the change.

Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov, @nsthorat, and @pyu10055)


tfjs-converter/package.json, line 58 at r1 (raw file):

Previously, lina128 (Na Li) wrote…

Yes, it is used in local yarn test. Although we symlinked core. We still have to build core to get the changes and install again to link to the change.

yup, basically you need the compiled outputs in tfjs-core/dist/... to be up-to-date

Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov, @nsthorat, and @pyu10055)

@lina128 lina128 requested a review from pyu10055 February 24, 2020 17:13
Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 2 of 1 approvals obtained (waiting on @nsthorat and @pyu10055)

@lina128 lina128 merged commit f4f0017 into tensorflow:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants