-
Notifications
You must be signed in to change notification settings - Fork 2k
update the README file to introduce the converter wizard CLI #2791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dsmilkov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 approvals obtained (waiting on @dsmilkov and @pyu10055)
tfjs-converter/README.md, line 59 at r1 (raw file):
There are two way to trigger the model conversion: - The conversion wizard: tensorflowjs_wizard
here, and the line below, wrap the command in quotes so it renders in <code>
tfjs-converter/README.md, line 65 at r1 (raw file):
```bash tensorflowjs_wizard
can you embed the animated gif here
tfjs-converter/README.md, line 69 at r1 (raw file):
This tool will walk you through the conversion process and provide you with details explanations for each choice you need to make. Behind the scene it calls the converter script (`tensorflowjs_converter`) in pip package. This is the easier
s/easier/recommended/
tfjs-converter/README.md, line 72 at r1 (raw file):
way to convert a single model. There is also dry run mode for the wizard, which will not perform the actual
also a dry
tfjs-converter/README.md, line 81 at r1 (raw file):
To convert a batch of models or integrate the conversion process into your own script, you should look into using the tensorflowjs_converter script.
s/look into using/use/
tfjs-converter/README.md, line 83 at r1 (raw file):
script, you should look into using the tensorflowjs_converter script. Here is detail information of parameters of the converter script.
instead of this sentence, just add a sub-heading here "Conversion using flags"
pyu10055
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the copy, PTAL, thanks.
Reviewable status: 0 of 1 approvals obtained
dsmilkov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ping!
Reviewed 2 of 2 files at r2.
Reviewable status:complete! 1 of 1 approvals obtained
tfjs-converter/README.md, line 59 at r1 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
here, and the line below, wrap the command in quotes so it renders in
<code>
FYI, you can use single quotes "`" for inline parts
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is