Skip to content

Conversation

@pyu10055
Copy link
Collaborator

@pyu10055 pyu10055 commented Feb 25, 2020

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 approvals obtained (waiting on @dsmilkov and @pyu10055)


tfjs-converter/README.md, line 59 at r1 (raw file):

There are two way to trigger the model conversion:

- The conversion wizard: tensorflowjs_wizard

here, and the line below, wrap the command in quotes so it renders in <code>


tfjs-converter/README.md, line 65 at r1 (raw file):

```bash
tensorflowjs_wizard

can you embed the animated gif here


tfjs-converter/README.md, line 69 at r1 (raw file):

This tool will walk you through the conversion process and provide you with
details explanations for each choice you need to make. Behind the scene it calls
the converter script (`tensorflowjs_converter`) in pip package. This is the easier

s/easier/recommended/


tfjs-converter/README.md, line 72 at r1 (raw file):

way to convert a single model.

There is also dry run mode for the wizard, which will not perform the actual

also a dry


tfjs-converter/README.md, line 81 at r1 (raw file):

To convert a batch of models or integrate the conversion process into your own
script, you should look into using the tensorflowjs_converter script.

s/look into using/use/


tfjs-converter/README.md, line 83 at r1 (raw file):

script, you should look into using the tensorflowjs_converter script.

Here is detail information of parameters of the converter script.

instead of this sentence, just add a sub-heading here "Conversion using flags"

Copy link
Collaborator Author

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the copy, PTAL, thanks.

Reviewable status: 0 of 1 approvals obtained

Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ping!

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained


tfjs-converter/README.md, line 59 at r1 (raw file):

Previously, dsmilkov (Daniel Smilkov) wrote…

here, and the line below, wrap the command in quotes so it renders in <code>

FYI, you can use single quotes "`" for inline parts

@pyu10055 pyu10055 merged commit 9594ad9 into master Mar 4, 2020
@pyu10055 pyu10055 deleted the convert_wizard_readme branch March 4, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants