[tfjs-converter] Add some fixes to converter wizard #2799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix dryrun arg not working * Enable tfjs-layers to tfjs-layers conversion path * Change conditions for split_weights_by_layer argument
Contributor
Author
|
@pyu10055 Hey, I encountered a few issues when using the wizard. Added fixes here 👍 |
pyu10055
approved these changes
Feb 27, 2020
Collaborator
pyu10055
left a comment
pyu10055
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 1 approvals obtained
pyu10055
reviewed
Feb 27, 2020
Collaborator
pyu10055
left a comment
pyu10055
left a comment
There was a problem hiding this comment.
thank you for fixing it!
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main, argv is a single element list containing a string representing all the args or an empty string for no args, so changed the checks to correctly detect--dryruntensorflowjs_converterCLI, but wasn't for the wizard.split_weights_by_layerargumentKeras H5 | Keras Saved Model->TFJS Layersconversion paths.This change is