-
Notifications
You must be signed in to change notification settings - Fork 2k
Modularize random distribution tensor creation ops #2939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lina128
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
nsthorat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 17 of 17 files at r1.
Reviewable status:complete! 2 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, @nsthorat, and @tafsiri)
tfjs-core/src/ops/multinomial.ts, line 23 at r1 (raw file):
import {TensorLike} from '../types'; import {op} from './operation'; /**
nit add blank line above this
tfjs-core/src/ops/multinomial.ts, line 63 at r1 (raw file):
return origRank === 1 ? res.as1D() : res; } export const multinomial = op({multinomial_});
nit add blank line above this
these nits for other files too (technically the style guide, not sure why lint doesnt do it)
|
Nice work!! |
tafsiri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 2 of 1 approvals obtained (waiting on @annxingyuan and @dsmilkov)
tfjs-core/src/ops/multinomial.ts, line 23 at r1 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
nit add blank line above this
Done
tfjs-core/src/ops/multinomial.ts, line 63 at r1 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
nit add blank line above this
these nits for other files too (technically the style guide, not sure why lint doesnt do it)
Done, here and elsewhere
dsmilkov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 13 of 17 files at r1, 4 of 4 files at r2.
Reviewable status:complete! 3 of 1 approvals obtained (waiting on @annxingyuan and @dsmilkov)
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is