Skip to content

Conversation

@tafsiri
Copy link
Contributor

@tafsiri tafsiri commented Mar 20, 2020

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

Copy link
Collaborator

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 17 of 17 files at r1.
Reviewable status: :shipit: complete! 2 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, @nsthorat, and @tafsiri)


tfjs-core/src/ops/multinomial.ts, line 23 at r1 (raw file):

import {TensorLike} from '../types';
import {op} from './operation';
/**

nit add blank line above this


tfjs-core/src/ops/multinomial.ts, line 63 at r1 (raw file):

  return origRank === 1 ? res.as1D() : res;
}
export const multinomial = op({multinomial_});

nit add blank line above this

these nits for other files too (technically the style guide, not sure why lint doesnt do it)

@nsthorat
Copy link
Contributor

Nice work!!

Copy link
Contributor Author

@tafsiri tafsiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 2 of 1 approvals obtained (waiting on @annxingyuan and @dsmilkov)


tfjs-core/src/ops/multinomial.ts, line 23 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

nit add blank line above this

Done


tfjs-core/src/ops/multinomial.ts, line 63 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

nit add blank line above this

these nits for other files too (technically the style guide, not sure why lint doesnt do it)

Done, here and elsewhere

Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 17 files at r1, 4 of 4 files at r2.
Reviewable status: :shipit: complete! 3 of 1 approvals obtained (waiting on @annxingyuan and @dsmilkov)

@tafsiri tafsiri merged commit 7f6c78a into master Mar 23, 2020
@tafsiri tafsiri deleted the mod-distributions branch March 23, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants