-
Notifications
You must be signed in to change notification settings - Fork 2k
[wasm] Test against head. #2953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nsthorat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @dsmilkov, @lina128, @nsthorat, @pyu10055, and @tafsiri)
tfjs-backend-wasm/package.json, line 24 at r1 (raw file):
"cpplint": "./scripts/cpplint.js", "lint": "tslint -p . -t verbose && yarn cpplint", "test": "yarn && yarn build-deps && yarn build && karma start",
one thing i realized, this means every time you run test you have to build all the dependency projects. this can slow things down -- is there any way to split these up (for all packages)? fine to submit as is for now, just something to think about.
dsmilkov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1.
Reviewable status:complete! 2 of 1 approvals obtained (waiting on @dsmilkov, @nsthorat, @pyu10055, and @tafsiri)
tfjs-backend-wasm/package.json, line 24 at r1 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
one thing i realized, this means every time you run test you have to build all the dependency projects. this can slow things down -- is there any way to split these up (for all packages)? fine to submit as is for now, just something to think about.
maybe we can add "test-dev" or "test-fast" across all repos, used for development. In general I like that "yarn test" is doing all the things since now that everything is at master, we will likely touch several files across packages in the same commit/PR.
lina128
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 2 of 1 approvals obtained (waiting on @dsmilkov, @nsthorat, @pyu10055, and @tafsiri)
tfjs-backend-wasm/package.json, line 24 at r1 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
maybe we can add "test-dev" or "test-fast" across all repos, used for development. In general I like that "yarn test" is doing all the things since now that everything is at master, we will likely touch several files across packages in the same commit/PR.
Thank you Nikhil and Daniel! Great suggestion. I can add a test-fast command for all repos in a separate PR.
This PR has below changes:
This change is