Skip to content

Conversation

@lina128
Copy link
Collaborator

@lina128 lina128 commented Mar 24, 2020

This PR has following changes:

  1. Remove master branch version update in release.ts script. Context: If we also have to update master branch every time releasing every package, 2 PRs need to be approved instead of 1, for each package. Also it runs tests redundantly, draining the CI resources too much. The version update in master is informational anyway, because the real version to be published will be in corresponding release branch. We will have other ways to provide version information, probably add a badge for npm version in readme.
  2. Change package.json version field and version.ts to 0.0.0 for each package. Context: Instead of deleting the field and the version.ts file altogether, we decided to keep change minimal.

This change is Reviewable

Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 16 of 16 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov and @nsthorat)

@lina128 lina128 merged commit b3f17bb into tensorflow:master Mar 24, 2020
@lina128 lina128 deleted the temp branch March 24, 2020 20:13
@lina128 lina128 mentioned this pull request Mar 25, 2020
@rthadur rthadur mentioned this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants