Skip to content

Fix release script. #2984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 30, 2020
Merged

Fix release script. #2984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
25b971c
Fix release.ts
lina128 Mar 25, 2020
975e861
Fix release.ts
lina128 Mar 25, 2020
618f0c9
Fix release.ts
lina128 Mar 27, 2020
1fa00ee
Fix publish script for node-gpu.
lina128 Mar 27, 2020
cfa16e4
Add comment for dep.
lina128 Mar 30, 2020
143dc47
Merge branch 'master' into release
lina128 Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions scripts/publish-npm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,11 @@ async function main() {

console.log(chalk.magenta.bold(`~~~ Preparing package ${pkg}~~~`));
console.log(chalk.magenta('~~~ Installing packages ~~~'));
// tfjs-node-gpu needs to get some files from tfjs-node.
if (pkg === "tfjs-node-gpu") {
$('yarn prep-gpu');
}

// Yarn above the other checks to make sure yarn doesn't change the lock file.
$('yarn');

Expand Down
5 changes: 4 additions & 1 deletion scripts/release-util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,12 @@ export const UNION_PHASE: Phase = {
deps: ['tfjs-core', 'tfjs-layers', 'tfjs-converter', 'tfjs-data']
};

// We added tfjs-core and tfjs-layers because Node has unit tests that directly
// use tf.core and tf.layers to test serialization of models. Consider moving
// the test to tf.layers.
export const NODE_PHASE: Phase = {
packages: ['tfjs-node', 'tfjs-node-gpu'],
deps: ['tfjs', 'tfjs-core'],
deps: ['tfjs', 'tfjs-core', 'tfjs-layers'],
scripts: {'tfjs-node-gpu': {'before-yarn': ['yarn prep-gpu']}}
};

Expand Down