ensure isMobile() does not fail when navigator is not set #3075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lina128
reviewed
Apr 13, 2020
Collaborator
lina128
left a comment
lina128
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @lina128 and @pyu10055)
tfjs-core/src/device_util.ts, line 23 at r1 (raw file):
// tslint:disable-next-line:no-any export function _isMobile(navigator: any): boolean { if (typeof navigator === 'undefined' && navigator == null) {
nit: Why not put this check in isMobile()? Then only call _isMobile when navigator is available.
pyu10055
commented
Apr 13, 2020
Collaborator
Author
pyu10055
left a comment
pyu10055
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @lina128)
tfjs-core/src/device_util.ts, line 23 at r1 (raw file):
Previously, lina128 (Na Li) wrote…
nit: Why not put this check in isMobile()? Then only call _isMobile when navigator is available.
main reason for testing, now I have added helper method, which I can mock.
lina128
approved these changes
Apr 14, 2020
Collaborator
lina128
left a comment
lina128
left a comment
There was a problem hiding this comment.
LGTM
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @lina128)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes tensorflow/tfjs-wechat#62
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is