Skip to content

Conversation

@tafsiri
Copy link
Contributor

@tafsiri tafsiri commented May 8, 2020

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @nsthorat, and @tafsiri)


tfjs-core/src/tensor.ts, line 929 at r1 (raw file):

  }
  /**
   * @deprecated strict variants of ops have been deprecated

do you want to add a console.warn like we did for 1.0? the method is still around: tf.setDeprecationWarn

Copy link
Contributor Author

@tafsiri tafsiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @annxingyuan and @nsthorat)


tfjs-core/src/tensor.ts, line 929 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

do you want to add a console.warn like we did for 1.0? the method is still around: tf.setDeprecationWarn

I added that to the op (non chained definition) itself so the runtime warning should still appear.

Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 2 of 1 approvals obtained (waiting on @annxingyuan and @tafsiri)


tfjs-core/src/tensor.ts, line 929 at r1 (raw file):

Previously, tafsiri (Yannick Assogba) wrote…

I added that to the op (non chained definition) itself so the runtime warning should still appear.

ah sorry!

@tafsiri tafsiri changed the title add deprecation warnings for strict variants deprecate strict variants of ops May 11, 2020
@tafsiri tafsiri merged commit 138f23a into master May 11, 2020
@tafsiri tafsiri deleted the deprecate-strict-ops branch May 11, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants