Skip to content

Conversation

@annxingyuan
Copy link
Contributor

@annxingyuan annxingyuan commented May 14, 2020

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@annxingyuan annxingyuan requested review from lina128 and tafsiri May 14, 2020 20:26
@annxingyuan annxingyuan self-assigned this May 14, 2020
Copy link
Collaborator

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 approvals obtained (waiting on @annxingyuan, @lina128, and @tafsiri)


tfjs-core/src/ops/space_to_batch_nd.ts, line 108 at r1 (raw file):

  const forward: ForwardFunc<T> = backend => {
    return backend.spaceToBatchND($x, blockShape, paddings);
  };

nit: backend => backend.spaceToBatchND($x, blockShape, paddings);


tfjs-core/src/public/chained_ops/space_to_batch_nd.ts, line 21 at r1 (raw file):

import {Rank} from '../../types';

declare module '../../tensor' {

Also remove from tensor.ts?

Copy link
Contributor Author

@annxingyuan annxingyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 approvals obtained (waiting on @lina128 and @tafsiri)


tfjs-core/src/ops/space_to_batch_nd.ts, line 108 at r1 (raw file):

Previously, lina128 (Na Li) wrote…

nit: backend => backend.spaceToBatchND($x, blockShape, paddings);

Done


tfjs-core/src/public/chained_ops/space_to_batch_nd.ts, line 21 at r1 (raw file):

Previously, lina128 (Na Li) wrote…

Also remove from tensor.ts?

Done

Copy link
Collaborator

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @lina128 and @tafsiri)

@annxingyuan annxingyuan merged commit 9c39366 into master May 14, 2020
@annxingyuan annxingyuan deleted the space_to_batch_mod branch May 14, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants