-
Notifications
You must be signed in to change notification settings - Fork 2k
Modularize spaceToBatchND. #3273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lina128
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 approvals obtained (waiting on @annxingyuan, @lina128, and @tafsiri)
tfjs-core/src/ops/space_to_batch_nd.ts, line 108 at r1 (raw file):
const forward: ForwardFunc<T> = backend => { return backend.spaceToBatchND($x, blockShape, paddings); };
nit: backend => backend.spaceToBatchND($x, blockShape, paddings);
tfjs-core/src/public/chained_ops/space_to_batch_nd.ts, line 21 at r1 (raw file):
import {Rank} from '../../types'; declare module '../../tensor' {
Also remove from tensor.ts?
annxingyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 approvals obtained (waiting on @lina128 and @tafsiri)
tfjs-core/src/ops/space_to_batch_nd.ts, line 108 at r1 (raw file):
Previously, lina128 (Na Li) wrote…
nit: backend => backend.spaceToBatchND($x, blockShape, paddings);
Done
tfjs-core/src/public/chained_ops/space_to_batch_nd.ts, line 21 at r1 (raw file):
Previously, lina128 (Na Li) wrote…
Also remove from tensor.ts?
Done
lina128
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @lina128 and @tafsiri)
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is