-
Notifications
You must be signed in to change notification settings - Fork 2k
[wasm] Add SIMD detection. #3344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lina128
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
tafsiri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one requested change (adding a generic async flag test in core).
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 2 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, @nsthorat, @pyu10055, and @tafsiri)
tfjs-backend-wasm/src/index_test.ts, line 142 at r1 (raw file):
}); it('evaluating async flag works', async () => {
These look good, but when we talked I was thinking you could add a test in core to test a generic async flag. That way whether this code goes away or not, the code paths introduced in core get tested.
annxingyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 2 of 1 approvals obtained (waiting on @dsmilkov, @nsthorat, @pyu10055, and @tafsiri)
tfjs-backend-wasm/src/index_test.ts, line 142 at r1 (raw file):
Previously, tafsiri (Yannick Assogba) wrote…
These look good, but when we talked I was thinking you could add a test in core to test a generic async flag. That way whether this code goes away or not, the code paths introduced in core get tested.
Done
Adds a flag to evaluate SIMD support.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is