Skip to content

nms perf #3351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2020
Merged

nms perf #3351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions tfjs-core/src/backends/non_max_suppression_impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,15 @@ function nonMaxSuppressionImpl_(
returnScoresTensor = false, padToMaxOutputSize = false): NamedTensorMap {
// The list is sorted in ascending order, so that we can always pop the
// candidate with the largest score in O(1) time.
const candidates =
Array.from(scores)
.map((score, boxIndex) => ({score, boxIndex, suppressBeginIndex: 0}))
.filter(c => c.score > scoreThreshold)
.sort(ascendingComparator);
const candidates = [];

for (let i = 0; i < scores.length; i++) {
if (scores[i] > scoreThreshold) {
candidates.push({ score: scores[i], boxIndex: i, suppressBeginIndex: 0 });
}
}

candidates.sort(ascendingComparator);

// If softNmsSigma is 0, the outcome of this algorithm is exactly same as
// before.
Expand Down