Modularise logical ops

[tafsiri]

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

---

This change is 

[lina128]

Reviewed 29 of 35 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @lina128 and @tafsiri)

---

tfjs-core/src/ops/unary_ops.ts, line 442 at r1 (raw file):

    const [$x] = saved;
    return {
      // tslint:disable-next-line: no-unnecessary-type-assertion

Does ts starts to throw error now?

---

tfjs-core/src/ops/where.ts, line 69 at r1 (raw file):

  // TODO(julianoks): Return null for condition gradient
  // when backprop supports it.
  const grad = (dy: T, saved: Tensor[]) => {

Should the grad be modularized?

[tafsiri]

Reviewable status: 0 of 1 approvals obtained (waiting on @lina128)

---

tfjs-core/src/ops/unary_ops.ts, line 442 at r1 (raw file):

Previously, lina128 (Na Li) wrote…

Does ts starts to throw error now?

in this case tslint believes the type assertion is unnecessary, but if you remove it tsc will not compile the file.

---

tfjs-core/src/ops/where.ts, line 69 at r1 (raw file):

Previously, lina128 (Na Li) wrote…

Should the grad be modularized?

Good catch, forgot to delete it here. Done.

[lina128]

Reviewable status: complete! 1 of 1 approvals obtained (waiting on @lina128)

---

tfjs-core/src/ops/unary_ops.ts, line 442 at r1 (raw file):

Previously, tafsiri (Yannick Assogba) wrote…

in this case tslint believes the type assertion is unnecessary, but if you remove it tsc will not compile the file.

That's weird, because the code was there before, meaning it compiles before~

[tafsiri]

Reviewable status: complete! 1 of 1 approvals obtained (waiting on @lina128)

---

tfjs-core/src/ops/unary_ops.ts, line 442 at r1 (raw file):

Previously, lina128 (Na Li) wrote…

That's weird, because the code was there before, meaning it compiles before~

True, but this may just be some weakness in the linter (note that its not the compiler complaining)