Remove debug from arg list. #3530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annxingyuan
approved these changes
Jun 30, 2020
tafsiri
approved these changes
Jun 30, 2020
Contributor
tafsiri
left a comment
tafsiri
left a comment
There was a problem hiding this comment.
Wow, thanks Na. This is bigger than I imagined when we talked. In webgl because this.debug is effectively part of backend states relatively clear what is being passed. Though it does make sense to me use the flag and not have to thread debug through all the method calls including the ones that don't use it, so that's a nice win from that perspective. +1
Reviewed 11 of 11 files at r1.
Reviewable status:complete! 2 of 1 approvals obtained (waiting on @tafsiri)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use env().getBool('DEBUG') instead. Fixes #3489
This change is