Skip to content

Conversation

@tafsiri
Copy link
Contributor

@tafsiri tafsiri commented Jun 30, 2020

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@tafsiri tafsiri changed the title chain all the chain ops. Move all the remaining chaining api outside of tensor.ts Jul 1, 2020
@tafsiri
Copy link
Contributor Author

tafsiri commented Jul 1, 2020

This is a large scale change that moves all the the remaining chaining api ops out of tensor.ts. Primarily done using code gen with hand editing after. Its a lot of files but very uniform type of change.

I went down this path (automation) for a couple of reasons:

  1. Speed up modularization workflow (3 less steps!)
  2. Make OpHandler and Tensor as slim as possible with respect to ops as we look ahead towards the work in the backends. In parallel i'm trying to define what precisely we want to keep as part of the tensor type which will have implications on the backend interface and possibly the TensorInfo object backends use. So moving these out is a step in clarifying what we want those interfaces to be. More to come on this in a doc after the holidays.
  3. I realized I wanted to move things like the strict* versions of ops out of tensor.ts so that it can be refactor independent of the actual removal of those functions from public api.

@tafsiri tafsiri marked this pull request as ready for review July 1, 2020 02:18
@tafsiri tafsiri requested review from annxingyuan and lina128 July 1, 2020 02:18
Copy link
Contributor

@annxingyuan annxingyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!! Thanks Yannick 😁

Copy link
Collaborator

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truly amazing!! Thank you Yannick! I also like that the public chained apis got doccomment too.

Reviewable status: :shipit: complete! 2 of 1 approvals obtained (waiting on @lina128)

@tafsiri tafsiri merged commit df5effd into master Jul 1, 2020
@tafsiri tafsiri deleted the auto-chain-ops branch July 1, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants