Modularize scatterNd, unsortedSegmentSum & gather.

[tafsiri]

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

---

This change is 

[lina128]

Reviewable status: complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @lina128, and @tafsiri)

---

tfjs-core/src/gradients/GatherV2_grad.ts, line 29 at r1 (raw file):

export const gatherGradConfig: GradConfig = {
  kernelName: GatherV2,
  inputsToSave: ['x', 'segmentIds'],

Should this be ['x', 'indices']?

---

tfjs-core/src/public/chained_ops/gather.ts, line 29 at r1 (raw file):

}

Tensor.prototype.gather = function<T extends Tensor>(

Curious, should we add doccomment for each chained ops? Or do we only add doccomment if the api is different than the ops, e.g. stack.

[tafsiri]

Reviewable status: complete! 1 of 1 approvals obtained (waiting on @annxingyuan and @lina128)

---

tfjs-core/src/gradients/GatherV2_grad.ts, line 29 at r1 (raw file):

Previously, lina128 (Na Li) wrote…

Should this be ['x', 'indices']?

Fixed.

---

tfjs-core/src/public/chained_ops/gather.ts, line 29 at r1 (raw file):

Previously, lina128 (Na Li) wrote…

Curious, should we add doccomment for each chained ops? Or do we only add doccomment if the api is different than the ops, e.g. stack.

Chained ops are not shown in our docs so we generally don't add jsdoc to them. the jsdoc of the main op should describe how to use it chained.

You raise an interesting point about stack. My initial reaction is that we should remove stack from chaining api if it is an exception. One should be able to trivially transform non chained to chained ops without looking up docs imo.