Skip to content

Fix min op test for nightly #3547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 3, 2020
Merged

Fix min op test for nightly #3547

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
704434f
use array close
pyu10055 Jul 2, 2020
cb7d06d
fix lint
pyu10055 Jul 2, 2020
2082889
Merge branch 'master' into fix_nightly
pyu10055 Jul 3, 2020
4057dc3
use array close
pyu10055 Jul 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tfjs-core/src/ops/min_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

import * as tf from '../index';
import {ALL_ENVS, describeWithFlags} from '../jasmine_util';
import {expectArraysClose, expectArraysEqual} from '../test_util';
import {expectArraysClose} from '../test_util';

describeWithFlags('min', ALL_ENVS, () => {
it('Tensor1D', async () => {
Expand All @@ -27,7 +27,7 @@ describeWithFlags('min', ALL_ENVS, () => {

it('ignores NaNs', async () => {
const a = tf.tensor1d([3, NaN, 2]);
expectArraysEqual(await tf.min(a).data(), 2);
expectArraysClose(await tf.min(a).data(), 2);
});

it('2D', async () => {
Expand Down Expand Up @@ -81,7 +81,7 @@ describeWithFlags('min', ALL_ENVS, () => {
tf.min(input, [1, 0]);

const inputDataAfter = await input.data();
expectArraysEqual(inputDataBefore, inputDataAfter);
expectArraysClose(inputDataBefore, inputDataAfter);
});

it('throws when passed a non-tensor', () => {
Expand Down