Skip to content

Conversation

@tafsiri
Copy link
Contributor

@tafsiri tafsiri commented Jul 7, 2020

Modularize sign, ceil, floor, neg.

Also improves tooling for speeding up modularization:

  • scripts/extract_op.ts will move ops from one file into their own file, and handle updating the old file as well as exports in ops.ts
  • scripts/touch_modular_ops_files.ts emits a more complete kernel template and also supports generating files for multiple ops and kernels in one call.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

Copy link
Contributor

@annxingyuan annxingyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! just curious - did you use the scripts you added to modularize sign / ceil / floor / neg? :)

@tafsiri
Copy link
Contributor Author

tafsiri commented Jul 7, 2020

@annxingyuan yep, if def helped speed it up. I also saw noticed that it is useful to make local modifications to templates when necessary, for example the gradient of the unary ops have a particular shared pattern, so as i do the rest i'll adapt the template to that pattern (but not commit that change).

@tafsiri tafsiri merged commit 05b5405 into master Jul 7, 2020
@tafsiri tafsiri deleted the extract-op-automation branch July 7, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants