Skip to content

Conversation

@annxingyuan
Copy link
Contributor

@annxingyuan annxingyuan commented Jul 20, 2020

This matches tfa.image.rotate and tf.rotate90.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@annxingyuan annxingyuan requested review from lina128 and tafsiri July 20, 2020 12:38
@annxingyuan annxingyuan changed the title Change image rotation kernel to be counterclockwise. Change image rotation kernel to be counterclockwise, add publish-local script to WASM. Jul 20, 2020
@annxingyuan annxingyuan requested a review from pyu10055 July 20, 2020 12:39
@annxingyuan annxingyuan self-assigned this Jul 20, 2020
Copy link
Collaborator

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ann, thank you for identifying this. Do you plan to add op rot90 too? This way, at least we can check for rotating 90 degrees the result is consistent with tf (by testing against Node backend).

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @lina128, @pyu10055, and @tafsiri)


tfjs-core/src/ops/rotate_with_offset_test.ts, line 69 at r1 (raw file):

  });

  it('should rotate negative 90 degrees', async () => {

Can we add whether it is clockwise or counter-clockwise?

Copy link
Contributor Author

@annxingyuan annxingyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Na, yes I plan to add rot90, along with tests for tf consistency.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @lina128, @pyu10055, and @tafsiri)


tfjs-core/src/ops/rotate_with_offset_test.ts, line 69 at r1 (raw file):

Previously, lina128 (Na Li) wrote…

Can we add whether it is clockwise or counter-clockwise?

Done

@annxingyuan annxingyuan changed the title Change image rotation kernel to be counterclockwise, add publish-local script to WASM. Change image rotation kernel to be counterclockwise. Jul 20, 2020
@annxingyuan annxingyuan merged commit 878005d into master Jul 20, 2020
@annxingyuan annxingyuan deleted the rotate_cc branch July 20, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants