Skip to content

Conversation

@pyu10055
Copy link
Collaborator

@pyu10055 pyu10055 commented Jul 22, 2020

This address the issues we are seeing with the ddsp model.

  1. cumsum the permutation logic is wrong, should to be able to reverse.
  2. strided_slice has issue with ellipsis mask is set and end indexes has negative value.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

Copy link
Contributor

@annxingyuan annxingyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ping!!!

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @annxingyuan)

@pyu10055 pyu10055 merged commit 2bc0ceb into master Jul 23, 2020
@pyu10055 pyu10055 deleted the ddsp_fixes branch July 23, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants