Skip to content

Conversation

@annxingyuan
Copy link
Contributor

@annxingyuan annxingyuan commented Aug 6, 2020

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@annxingyuan annxingyuan requested a review from tafsiri August 6, 2020 18:36
@annxingyuan annxingyuan self-assigned this Aug 6, 2020
Copy link
Contributor

@tafsiri tafsiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @annxingyuan and @tafsiri)


tfjs-backend-wasm/scripts/create-worker-module.js, line 29 at r1 (raw file):

const workerContents = fs.readFileSync(WORKER_PATH, "utf8");
fs.writeFileSync(`${BASE_PATH}tfjs-backend-wasm-threaded-simd.worker.js`,

reuse WORKER_PATH here


tfjs-backend-wasm/scripts/create-worker-module.js, line 30 at r1 (raw file):

const workerContents = fs.readFileSync(WORKER_PATH, "utf8");
fs.writeFileSync(`${BASE_PATH}tfjs-backend-wasm-threaded-simd.worker.js`,
  `export const wasmWorkerContents = '${workerContents}';`);

does it not need trim anymore?

Copy link
Contributor

@tafsiri tafsiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @annxingyuan and @tafsiri)


tfjs-backend-wasm/src/backend_wasm.ts, line 23 at r1 (raw file):

import {BackendWasmModule, WasmFactoryConfig} from '../wasm-out/tfjs-backend-wasm';
import wasmFactoryThreadedSimd from '../wasm-out/tfjs-backend-wasm-threaded-simd.js';
// @ts-ignore

you may not need this anymore

Copy link
Contributor Author

@annxingyuan annxingyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @tafsiri)


tfjs-backend-wasm/scripts/create-worker-module.js, line 29 at r1 (raw file):

Previously, tafsiri (Yannick Assogba) wrote…

reuse WORKER_PATH here

Done


tfjs-backend-wasm/scripts/create-worker-module.js, line 30 at r1 (raw file):

Previously, tafsiri (Yannick Assogba) wrote…

does it not need trim anymore?

Done


tfjs-backend-wasm/src/backend_wasm.ts, line 23 at r1 (raw file):

Previously, tafsiri (Yannick Assogba) wrote…

you may not need this anymore

if I remove this then we would need a declaration file - do you think it's worth it to create one or maybe fine to leave the ts-ignore?

@tafsiri
Copy link
Contributor

tafsiri commented Aug 6, 2020

@annxingyuan totally fine to leave the ts-ignore in then :)

@tafsiri tafsiri merged commit b9e155d into master Aug 6, 2020
@tafsiri tafsiri deleted the fix_worker branch August 6, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants