Skip to content

Conversation

@Linchenn
Copy link
Collaborator

@Linchenn Linchenn commented Aug 11, 2020

Similar to optional inputs in profileKernel, #3697, the optional inputs in profiler.Logger also should be accounted. (The preluactivationweights is an optional input to fusedConv2D)

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@Linchenn Linchenn requested review from lina128 and pyu10055 August 11, 2020 15:38
Copy link
Collaborator Author

@Linchenn Linchenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 approvals obtained (waiting on @lina128 and @pyu10055)


tfjs-core/src/profiler_test.ts, line 221 at r1 (raw file):

});

describeWithFlags('profiler.Logger', ALL_ENVS, () => {

The Logger can be called in all environments, so I use ALL_ENVS here.

Copy link
Collaborator

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewable status: 0 of 1 approvals obtained (waiting on @lina128 and @pyu10055)

@lina128 lina128 requested review from annxingyuan and lina128 August 11, 2020 17:14
Copy link
Contributor

@annxingyuan annxingyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Linchenn !

@Linchenn
Copy link
Collaborator Author

Thank you too! :D

@Linchenn Linchenn merged commit 06b5ec8 into tensorflow:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants