Skip to content

Organize the benchmark toolkit #3793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 13, 2020
Merged

Organize the benchmark toolkit #3793

merged 6 commits into from
Aug 13, 2020

Conversation

@Linchenn
Copy link
Collaborator

@Linchenn Linchenn commented Aug 13, 2020 •
edited by nsthorat
Loading

This PR does the following:

  1. Migrate local-benchmark tool to a separate folder. Then the files under tfjs/e2e/benchmarks/ are shared between browserstack-benchmark and local-benchmark, increasing readability.
  2. Separate test runners (SpecRunner.html) for:
    • The shared codes under tfjs/e2e/benchmarks/
    • browserstack-benchmark
    • local-benchmark

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

This change is Reviewable

Linchenn
Linchenn commented Aug 13, 2020
View reviewed changes
@Linchenn Linchenn requested a review from annxingyuan August 13, 2020 17:34
@Linchenn Linchenn requested review from lina128 and pyu10055 August 13, 2020 17:40
@Linchenn Linchenn merged commit ff3147d into tensorflow:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lina128 lina128 lina128 approved these changes

@annxingyuan annxingyuan Awaiting requested review from annxingyuan

@pyu10055 pyu10055 Awaiting requested review from pyu10055

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Linchenn @lina128 @annxingyuan @googlebot