Skip to content

Conversation

@rthadur
Copy link
Contributor

@rthadur rthadur commented Aug 13, 2020

fixes #3611

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@rthadur rthadur requested a review from pyu10055 August 13, 2020 18:23
Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Reviewable status: 0 of 1 approvals obtained (waiting on @pyu10055 and @rthadur)


tfjs-converter/python/tensorflowjs/converters/keras_h5_conversion_test.py, line 172 at r1 (raw file):

    h5_path = os.path.join(self._tmp_dir, 'MyModelMerged.h5')
    model.save(h5_path)
    if six.PY3:

this is failing for python 2.x
E:172, 7: Undefined variable 'six' (undefined-variable)
E:221, 7: Undefined variable 'six' (undefined-variable)

@rthadur rthadur requested a review from pyu10055 August 14, 2020 06:21
@pyu10055 pyu10055 merged commit d0a20e3 into master Aug 15, 2020
@pyu10055 pyu10055 deleted the rthadur-patch-4 branch August 15, 2020 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

encoding parameter to json.loads was deprecated and removed in Python 3.9

3 participants